Skip to content

Commit

Permalink
Fixed crash in FixRenderCommandList()
Browse files Browse the repository at this point in the history
We can skip whole CGEN_LIGHTING_DIFFUSE
  • Loading branch information
TheDushan committed Feb 28, 2021
1 parent 7433dec commit b342532
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CMakeLists.txt
Expand Up @@ -148,6 +148,7 @@ set( GPURENDERER_HEADERS
${MOUNT_DIR}/GPURenderer/r_splash.hpp
${MOUNT_DIR}/API/renderer_api.hpp
${MOUNT_DIR}/GPURenderer/r_types.hpp
${MOUNT_DIR}/GPURenderer/r_cmdsTemplate.hpp
)

set( GPURENDERER_SOURCES
Expand Down
5 changes: 2 additions & 3 deletions src/engine/GPURenderer/r_shader.cpp
Expand Up @@ -1528,8 +1528,7 @@ static bool ParseStage( shaderStage_t* stage, valueType** text )
// decide which agens we can skip
if( stage->alphaGen == AGEN_IDENTITY )
{
if( stage->rgbGen == CGEN_IDENTITY
|| stage->rgbGen == CGEN_LIGHTING_DIFFUSE )
if( stage->rgbGen == CGEN_IDENTITY /* || stage->rgbGen == CGEN_LIGHTING_DIFFUSE*/ )
{
stage->alphaGen = AGEN_SKIP;
}
Expand Down Expand Up @@ -3303,7 +3302,7 @@ static void FixRenderCommandList( sint newShader )
sortedIndex = ( ( drawSurf->sort >> QSORT_SHADERNUM_SHIFT ) & ( MAX_SHADERS - 1 ) );
if( sortedIndex >= newShader )
{
sortedIndex++;
sortedIndex = shader->sortedIndex;
drawSurf->sort = ( sortedIndex << QSORT_SHADERNUM_SHIFT ) | entityNum | ( fogNum << QSORT_FOGNUM_SHIFT ) | ( ( sint )pshadowMap << QSORT_PSHADOW_SHIFT ) | ( sint )dlightMap;
}
}
Expand Down

0 comments on commit b342532

Please sign in to comment.