Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support querying multiple networks #655

Closed
Isaac-DeFrain opened this issue Mar 22, 2024 · 4 comments · Fixed by #841
Closed

Support querying multiple networks #655

Isaac-DeFrain opened this issue Mar 22, 2024 · 4 comments · Fixed by #841
Assignees
Labels
Data Database, storage or retrieval of data, JSON, serialization, etc.
Milestone

Comments

@Isaac-DeFrain
Copy link
Member

We should expand the cli query args to have an optional flag --network which defaults to "mainnet"

@jhult
Copy link
Collaborator

jhult commented Mar 25, 2024

@Isaac-DeFrain, you mean a global option/flag for all commands?

@jhult
Copy link
Collaborator

jhult commented Mar 26, 2024

Related to #650.

@robinbb
Copy link
Member

robinbb commented Mar 27, 2024

Perhaps so, but this begs the question: will the indexer work with 2 different networks simultaneously? Or, maybe we need to work with some network, but only one network.

@Isaac-DeFrain
Copy link
Member Author

My thinking is that we now index almost everything in the db by network so it is possible to make queries on multiple networks. The indexer will only ever be "running" on one network at a time but that network may change, e.g. with the hardfork. I'm envisioning the indexer running on current mainnet and having the ability to upgrade to the new network without downtime, after which we can query all old and new network data

@robinbb robinbb added this to the Maintenance milestone Apr 2, 2024
@jhult jhult self-assigned this May 7, 2024
jhult added a commit that referenced this issue May 7, 2024
jhult added a commit to jhult/mina-indexer that referenced this issue May 7, 2024
jhult added a commit to jhult/mina-indexer that referenced this issue May 7, 2024
jhult added a commit to jhult/mina-indexer that referenced this issue May 7, 2024
jhult added a commit to jhult/mina-indexer that referenced this issue May 8, 2024
trevorbernard pushed a commit to jhult/mina-indexer that referenced this issue May 8, 2024
jhult added a commit to jhult/mina-indexer that referenced this issue May 9, 2024
@jhult jhult changed the title Problem: "mainnet" network hardcoded in client queries Support querying multiple networks May 9, 2024
@jhult jhult added the Data Database, storage or retrieval of data, JSON, serialization, etc. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Database, storage or retrieval of data, JSON, serialization, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants