Improvement: refine CLI commands, arguments, and communication with server documentation #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Isaac-DeFrain, I know some tests are failing, but I am not sure where I caused the issues. It looks like on this one there was an unexpected end reading from the socket due to additional bytes. |
jhult
commented
Mar 27, 2024
jhult
force-pushed
the
feat/650-cli
branch
2 times, most recently
from
67fe410
to
e34359f
Compare
Turns out the buffer size (via |
|
I like all the structural changes and it simplifies our manual unrolling of the payload. I have some subjective comments that doesn't affect the validity of this PR. |
trevorbernard
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #650.
Many of these commits could (should?) be squashed. I have left them for the moment for ease of review (commit-by-commit).