Enhancement: store date_time in SignedCommandWithData and add functions to better store/retrieve transactions #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhult
force-pushed
the
enhancement/indexer-store-trx-storage-retrieval
branch
3 times, most recently
from
80e566e
to
00c082d
Compare
|
I strongly prefer keeping the entire impl block in one file (keep the |
jhult
force-pushed
the
enhancement/indexer-store-trx-storage-retrieval
branch
from
00c082d
to
815e794
Compare
jhult
requested review from
trevorbernard,
robinbb and
Isaac-DeFrain
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as a blocker for #554.
I split this PR into multiple commits for easier review.
move CommandStore into command/store - This isn't strictly necessary, but seems like a good move to me. We can drop this commit if we don't want this.