Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: GraphQL - transactions #769

Merged
merged 3 commits into from Apr 12, 2024

Conversation

jhult
Copy link
Collaborator

@jhult jhult commented Apr 9, 2024

Implements transactions (#554)

@jhult jhult self-assigned this Apr 9, 2024
@jhult jhult changed the title Feat: GraphQL - transactions+ Feat: GraphQL - transactions Apr 10, 2024
@jhult jhult force-pushed the feat/graphql/txns branch 2 times, most recently from 105d86f to 74ef246 Compare April 10, 2024 04:38
@jhult
Copy link
Collaborator Author

jhult commented Apr 10, 2024

I plan to add one or more tests (perhaps as part of #698 but ideally as part of this PR).

I'm moving this from Draft to Ready for review to get comments on the current code.

@jhult jhult marked this pull request as ready for review April 10, 2024 17:24
Copy link
Member

@Isaac-DeFrain Isaac-DeFrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @trevorbernard review too. My only ask is for a regression test that queries the new endpoint

rust/src/web/graphql/transactions/mod.rs Outdated Show resolved Hide resolved
rust/src/web/graphql/transactions/mod.rs Show resolved Hide resolved
@Isaac-DeFrain Isaac-DeFrain assigned trevorbernard and unassigned jhult Apr 10, 2024
@jhult jhult force-pushed the feat/graphql/txns branch 3 times, most recently from 8c941bd to ecd62c4 Compare April 12, 2024 04:15
rust/src/web/graphql/transactions/mod.rs Outdated Show resolved Hide resolved
rust/src/web/graphql/transactions/mod.rs Outdated Show resolved Hide resolved
rust/src/web/graphql/transactions/mod.rs Outdated Show resolved Hide resolved
@trevorbernard trevorbernard merged commit 481f63b into Granola-Team:main Apr 12, 2024
3 checks passed
@jhult jhult deleted the feat/graphql/txns branch April 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants