New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: GraphQL - transactions #769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhult
force-pushed
the
feat/graphql/txns
branch
2 times, most recently
from
April 10, 2024 04:38
105d86f
to
74ef246
Compare
I plan to add one or more tests (perhaps as part of #698 but ideally as part of this PR). I'm moving this from Draft to Ready for review to get comments on the current code. |
jhult
requested review from
trevorbernard,
robinbb and
Isaac-DeFrain
as code owners
April 10, 2024 17:24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @trevorbernard review too. My only ask is for a regression test that queries the new endpoint
jhult
force-pushed
the
feat/graphql/txns
branch
3 times, most recently
from
April 12, 2024 04:15
8c941bd
to
ecd62c4
Compare
trevorbernard
requested changes
Apr 12, 2024
jhult
force-pushed
the
feat/graphql/txns
branch
from
April 12, 2024 16:46
ecd62c4
to
7475715
Compare
trevorbernard
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements transactions (#554)