Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default P key binding to toggle ranks table #2

Closed
GrantJL opened this issue Oct 7, 2022 · 1 comment
Closed

Remove default P key binding to toggle ranks table #2

GrantJL opened this issue Oct 7, 2022 · 1 comment
Assignees
@GrantJL
Labels
improvement Improvement or adjustment to existing feature

Comments

@GrantJL
Copy link
Owner

GrantJL commented Oct 7, 2022

Summary

Pressing the P key toggles the Lobby Ranks table by default. There is no scope on pressing this key as as such the table opens even from typing P in chat.

Remove this binding by default allowing users to bind this themselves using the BakkesMod Binding menu.
@GrantJL GrantJL self-assigned this Oct 7, 2022
GrantJL added a commit that referenced this issue Oct 7, 2022
@GrantJL
Remove default P toggle table keybinding
4d09362 
- Removed default `P` toggle show kebinding
- Separated Plugin Settings GUI to new cpp
- Misc re-working and whitespace removal

Working #2
@GrantJL
Copy link
Owner Author

GrantJL commented Oct 7, 2022

Fixed in above commit.

@GrantJL GrantJL closed this as completed Oct 7, 2022
@GrantJL GrantJL added the improvement Improvement or adjustment to existing feature label Oct 27, 2022
@GrantJL GrantJL mentioned this issue Oct 27, 2022
Closed
@GrantJL GrantJL mentioned this issue Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GrantJL GrantJL

Labels
improvement Improvement or adjustment to existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GrantJL