RMS time projector #129
Merged
RMS time projector #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 13, 2021 16:12
Rlamboll
reviewed
May 18, 2021
There was a problem hiding this comment.
Looking good so far on the coding side. Things that need doing still:
- Update the changelog to mention this added feature
- Several lines in the notebook are out-of-date or hard to read. The intro still says there is only one tool, for instance. The legends on the plots could be more useful to explain which of the lines is the infilled one (particularly since it overlaps one of the pre-existing lines) - maybe make the infilled line dashed so we can see both?
|
Rlamboll
approved these changes
May 18, 2021
| @@ -5,6 +5,7 @@ Work in progress | |||
| Added | |||
| ~~~~~ | |||
| - (`#126 <https://github.com/GranthamImperial/silicone/pull/126>`_) Added the first time projector (Extend latest time quantile) that extends a pathway to cover later times, assuming it remains at the same quantile. | |||
| - (`#129 <https://github.com/GranthamImperial/silicone/pull/129>`_) Added an additional time projector (Extend RMS closest) that extends a pathway to cover later times by selecting future data from the closest pathway. | |||
There was a problem hiding this comment.
This should go above 126, since it came later. This way people only need to read the top items to get back on track. Description is good though.
There was a problem hiding this comment.
Thanks, corrected.
| @@ -7,3 +7,4 @@ | |||
| """ | |||
|
|
|||
| from .extend_latest_time_quantile import ExtendLatestTimeQuantile # noqa: F401 | |||
| from .extend_rms_closest import ExtendRMSClosest | |||
There was a problem hiding this comment.
Our linter doesn't seem to mind, but adding the # noqa: F401 command means that using a proper linter won't complain that we're not going to get error messages about the fact that these imports aren't used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rstaddedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: