Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple infiller decompose #44

Merged
merged 11 commits into from
Feb 19, 2020
Merged

Multiple infiller decompose #44

merged 11 commits into from
Feb 19, 2020

Conversation

Rlamboll
Copy link
Collaborator

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • [] Example added (either to an existing notebook or as a new notebook, where applicable) (not yet, next commit)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

@Rlamboll
Copy link
Collaborator Author

This is to be done after #43

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          16       16           
  Lines         637      637           
  Branches      119      119           
=======================================
  Hits          634      634           
  Misses          1        1           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f4d46...d30ed33. Read the comment docs.

@Rlamboll
Copy link
Collaborator Author

The notebook where this is used is in PR #45 . It constructs a consistent basket in the infiller data and then breaks it down into several components.

Copy link
Collaborator

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great documentation and tests!

Comment on lines +10 to +12
# from .infill_all_required_emissions_for_openscm import (
# infill_all_required_variables,
#) # noqa: F401
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to keep this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will get uncommented in the next PR

@Rlamboll Rlamboll merged commit d30ed33 into master Feb 19, 2020
@Rlamboll Rlamboll deleted the multiple_infiller_decompose branch February 19, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants