-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple infiller decompose #44
Conversation
This is to be done after #43 |
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 16 16
Lines 637 637
Branches 119 119
=======================================
Hits 634 634
Misses 1 1
Partials 2 2 Continue to review full report at Codecov.
|
The notebook where this is used is in PR #45 . It constructs a consistent basket in the infiller data and then breaks it down into several components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great documentation and tests!
# from .infill_all_required_emissions_for_openscm import ( | ||
# infill_all_required_variables, | ||
#) # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will get uncommented in the next PR
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: