Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problems referenced by minor todos and removed the todos. #62

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

Rlamboll
Copy link
Collaborator

Pull request

Please confirm that this pull request has done the following:

  • Tests added (none needed)
  • Documentation added (where applicable) (none)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #62 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          18       18           
  Lines         788      788           
  Branches      166      166           
=======================================
  Hits          774      774           
  Misses          8        8           
  Partials        6        6           
Impacted Files Coverage Δ
src/silicone/utils.py 100.00% <ø> (ø)
src/silicone/database_crunchers/rms_closest.py 100.00% <100.00%> (ø)
...llers/infill_all_required_emissions_for_openscm.py 90.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9f249...5a37738. Read the comment docs.

@Rlamboll Rlamboll merged commit 00e8ca6 into master Mar 19, 2020
@Rlamboll Rlamboll deleted the solve_todos branch March 19, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants