Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input #66

Merged
merged 11 commits into from
Mar 26, 2020
Merged

Remove input #66

merged 11 commits into from
Mar 26, 2020

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Mar 24, 2020 •
edited
Loading

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

Closes #56

@znicholls znicholls marked this pull request as ready for review March 25, 2020 01:46
@znicholls znicholls requested a review from Rlamboll March 25, 2020 01:46
Rlamboll
Rlamboll reviewed Mar 25, 2020
View reviewed changes
src/silicone/utils.py Outdated Show resolved Hide resolved
tests/unit/test_utils.py Show resolved Hide resolved
src/silicone/utils.py Show resolved Hide resolved
Rlamboll
Rlamboll reviewed Mar 26, 2020
View reviewed changes
src/silicone/utils.py Outdated Show resolved Hide resolved
@Rlamboll
Copy link
Collaborator

More generally, run black on this. There's several overlong lines here. Also chnage the chnage

@Rlamboll
Copy link
Collaborator

Sorry, that last comment should have been on the test_utils

@znicholls
Copy link
Collaborator Author

Sorted now I believe

Rlamboll
Rlamboll reviewed Mar 26, 2020
View reviewed changes
tests/unit/test_utils.py Outdated Show resolved Hide resolved
znicholls and others added 2 commits March 26, 2020 11:59
@znicholls @Rlamboll
Update tests/unit/test_utils.py
cd78621 
Co-Authored-By: Rlamboll <rlamboll@hotmail.co.uk>
@znicholls
Fix up tests
8f897ee
@znicholls znicholls merged commit ff23d87 into master Mar 26, 2020
@znicholls znicholls deleted the 56-remove-input branch March 26, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rlamboll Rlamboll Rlamboll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Input
2 participants
@znicholls @Rlamboll