Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rms closest bug #69

Merged
merged 6 commits into from Mar 26, 2020
Merged

Fix rms closest bug #69

merged 6 commits into from Mar 26, 2020

Conversation

Rlamboll
Copy link
Collaborator

@Rlamboll Rlamboll commented Mar 25, 2020 •
edited by znicholls

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added (waiting to avoid merge conflicts)

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

@Rlamboll Rlamboll requested a review from jkikstra March 25, 2020 15:24
znicholls
znicholls reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the bug? That you could pass in a database with no overlap and no error would be raised?

src/silicone/database_crunchers/rms_closest.py Outdated Show resolved Hide resolved
@Rlamboll
Copy link
Collaborator Author

n

The closest pathway didn't necessarily have any data for the follower, in which case nothing is actually infilled.

znicholls
znicholls reviewed Mar 26, 2020
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@Rlamboll @znicholls
Update CHANGELOG.rst
ae4f9ab 
Co-Authored-By: Zeb Nicholls <zebedee.nicholls@climate-energy-college.org>
@znicholls
Copy link
Collaborator

lgtm, will leave for @jkikstra to finalise

@Rlamboll Rlamboll removed the request for review from jkikstra March 26, 2020 14:33
@Rlamboll
Copy link
Collaborator Author

Turns out @jkikstra is super-busy so maybe you can ok it @znicholls

znicholls
znicholls approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@znicholls znicholls left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (one v minor suggestion) thanks @Rlamboll !

src/silicone/multiple_infillers/infill_all_required_emissions_for_openscm.py Outdated Show resolved Hide resolved
@Rlamboll @znicholls
Update src/silicone/multiple_infillers/infill_all_required_emissions_…
811b858 
…for_openscm.py

Co-Authored-By: Zeb Nicholls <zebedee.nicholls@climate-energy-college.org>
@Rlamboll Rlamboll merged commit 16da5e7 into master Mar 26, 2020
@Rlamboll Rlamboll deleted the fix_rms_closest branch March 26, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholls znicholls znicholls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rlamboll @znicholls