Change cruncher names #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atio (prev. lead_gas)
znicholls
approved these changes
Apr 5, 2020
CHANGELOG.rst
Outdated
| @@ -4,6 +4,7 @@ Changelog | |||
| master | |||
| ------ | |||
|
|
|||
| - (`#80 <https://github.com/znicholls/silicone/pull/80>`_) Changed the names of crunchers for brevity. Changed ``lead_gas`` to ``latest_time_ratio`` and gave it documentation. | |||
There was a problem hiding this comment.
Suggested change
| - (`#80 <https://github.com/znicholls/silicone/pull/80>`_) Changed the names of crunchers for brevity. Changed ``lead_gas`` to ``latest_time_ratio`` and gave it documentation. | |
| - (`#80 <https://github.com/znicholls/silicone/pull/80>`_) Changed the names of crunchers for brevity. Also changed ``lead_gas`` to ``latest_time_ratio`` and added a notebook for this cruncher. |
There was a problem hiding this comment.
Compromise: Changed the names of crunchers for brevity. Also changed lead_gas to latest_time_ratio and included it in ratio notebook.
added 2 commits
April 6, 2020 00:11
…silicone into change_cruncher_names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rstaddedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: