-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
granulate-utils: Fix resolve_proc_root_links #221
granulate-utils: Fix resolve_proc_root_links #221
Conversation
2a1b64c
to
c816d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review yet, but just one note - there are several tests in gprofiler which test this function's behavior. Please create a PR in gprofiler which points to this commit so the tests run agains this commit. (Plus, post merging we'll want to update gprofiler as well).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core change is clear and looks good to me. I gave 2 nitpick comments. @michelhe as this is a very core part, please review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, 1 small comment and a question -
Wouldn't nsentring to the process mount namespace and then simply readlink()
inside the namespace will serve the same purpose, but we'll have the OS do the resolving for us?
Fix resolve_proc_root_links handling of links that resolve to sub-path links.
Example: