Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Text components are removed with an error if they are dragged while you are editing their contents #2294

Closed
tom-sherman opened this issue Sep 26, 2019 · 0 comments · Fixed by #2295
Closed

[Bug] Text components are removed with an error if they are dragged while you are editing their contents #2294

tom-sherman opened this issue Sep 26, 2019 · 0 comments · Fixed by #2295
Labels
bug
Projects
Release v0.15.9

Comments

@tom-sherman
Copy link
Contributor

tom-sherman commented Sep 26, 2019 •
edited

This can replicated in the demo: https://grapesjs.com/demo.html

  1. Drag in a text node
  2. Double click to activate the RTE
  3. Drag the text component into another position
  4. Select another component

The component is removed and the following error is logged to the console:

Uncaught TypeError: Cannot read property 'tagName' of null
    at r.toggleEvents (ComponentTextView.js:165)
    at r.disableEditing (ComponentTextView.js:71)
tom-sherman added a commit to tom-sherman/grapesjs that referenced this issue Sep 26, 2019
@tom-sherman
Guard against parentNode being undefined
c2ecf4b 
Fixes GrapesJS#2294
@tom-sherman tom-sherman mentioned this issue Sep 26, 2019
Merged
@artf artf added the bug label Sep 28, 2019
@artf artf added this to To do in Release v0.15.9 via automation Sep 28, 2019
Release v0.15.9 automation moved this from To do to Done Sep 28, 2019
artf added a commit that referenced this issue Oct 6, 2019
@artf
Fix text component issue on toolbar commands execution. Closes #2294
6f566ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
No open projects
Release v0.15.9
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guard against parentNode being undefined when calling toggleEvents tom-sherman/grapesjs
2 participants
@tom-sherman @artf