Calibrate the coordinates based on frame position. #2375
Conversation
Merge dev in master
Merge dev
component.setDragMode('absolute') and then start dragging, you'd get a lot of
`editor is not defined` errors.
Since the toolbar lives outside the canvas frame, the event's generated on it have clientX and clientY relative to the page. This makes sure we consider frame offset from the page. Fixes GrapesJS#2207,GrapesJS#2372
Define editor first
Merge dev
|
@artf Any chance we could review and merge this? |
|
I updated the branch to resolve conflicts. |
|
Thanks @emilsedgh ❤️ |
|
when can expect to be pushed this changes to npm repo |
|
@ramusesan I'll try to find time to release it tomorrow |
|
@artf ok thanks, I will be waiting |
|
What happens when i change device and the component stay outside of canvas? this's not working maybe
|
The outline boxes keep track of the components even outside of their frames |
I'm talking about the calibration of coordinates x/y in the |
Calibrate the coordinates based on frame position.
Since the toolbar lives outside the canvas frame, the event's generated on it
have clientX and clientY relative to the page
This patch makes sure we consider frame offset from the page.
Fixes #2207,#2372