Replaced the position absolutes with flex instead in Layers view #5422
Conversation
mapsmarketing
changed the title
There was a problem hiding this comment.
Thank you @mapsmarketing, I really appreciate this PR ❤️
Besides a few comments, I'd also ask to check this regression with borders I see here
src/styles/scss/_gjs_layers.scss
Outdated
| overflow: hidden; | ||
| white-space: nowrap; |
There was a problem hiding this comment.
Any reason behind removing these? Those properties are used to apply ellipsis to long layer names.
There was a problem hiding this comment.
Thank you very much on your feedback @artf :)
It's dark-on-dark and I'm blind as a bat, so didn't see the border underneath :D Will fix this up and the CSS code for the ellipsis. I'll resubmit once I've got it updated.
There was a problem hiding this comment.
Hi @artf
I've made the requested fixes. Please let me know if you require anything further.
Thank you very much Artur
|
@mapsmarketing I made some other small fixes/changes but overall you did a great job, thank you very much 🙇♂️ |
|
Glad it was useful and thank you very much @artf |
Hi there,
I've only just recently come across this amazing software and felt I could contribute. My contribution is small and it mainly tackles the layers panel. I noticed that
position: absolute;is used quite a lot to position the elements which I thought was unnecessary since it can be done more cleanly withdisplay: flex;instead.This is my first time contributing, so please let me know if I've done anything wrong or if further details are required.
Thank you very much