Bugfix/5650 inserting text uses model data not current view #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2024 06:03
bgrand-ch
suggested changes
Jan 31, 2024
| @@ -182,13 +182,13 @@ export default class ComponentTextView extends ComponentView<ComponentText> { | |||
| const offset = range.startOffset; | |||
| const textModel = getComponentModel(textNode); | |||
| const newCmps: (ComponentDefinition | Component)[] = []; | |||
|
|
|||
| let data = textNode.textContent ?? ''; | |||
There was a problem hiding this comment.
suggestion: const data = textNode.textContent || '';, because the data is not updated afterwards.
| if (textModel && textModel.is?.('textnode')) { | ||
| const cmps = textModel.collection; | ||
| cmps.forEach(cmp => { | ||
| if (cmp === textModel) { | ||
| const type = 'textnode'; | ||
| const cnt = cmp.content; | ||
| const cnt = (data = '' ? cmp.content : data); |
There was a problem hiding this comment.
important: use equality operator (==) or strict equality operator (===)
suggestion: const cnt = data || cmp.content;
bgrand-ch
approved these changes
Feb 1, 2024
|
This might lead to unexpected behavior as it's not always the case I want to use the DOM content. I'd accept this only behind an additional option flag (eg. |
…n the options object
|
@artf I have wrapped the code to test if that property exists and if it's true. That way content is only replaced if insertComponent(xx, { useDomContent: true }) is used |
artf
approved these changes
Feb 19, 2024
|
Thanks @Wayne-Mather |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed solution for the bug 5650 when inserting text into a text node that has not synchronised back to the model yet.
BUG: When inserting text when component not synced, the text is overwritten from the existing model