support mj-wrapper with background-url and full-width #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @artf , here is a PR to propose a fix in the mjml plugin.
When applying a background image to a full-width wrapper, the mjml compiler generates an html tree that does not match with the
getChildrenSelector
ofWrapper
and the javascript crash with the following error:This can be reproduced by either setting a wrapper in full-width and adding a background image to it from the editor or by importing an MJML with this kind of component, like in the next example:
The cause is that when using a
background-url
attribute, mjml use two successive<div>
before the second<table>
.This PR fixes the issue by considering any number of level between the first
<div>
and the next<table>
.This is the current behavior for
Section.getChildrenSelector()
already and replicated here inWrapper
.