Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): add examples for next image and gatsby link #16

Merged

Conversation

jpedroschmitz
Copy link
Member

@jpedroschmitz jpedroschmitz commented Jul 21, 2021

Unfortunately, I couldn't figure out an implementation for gatsby-plugin-image. I've tried using the StaticImage, but it didn't work as expected. The GatsbyImage component (for dynamic images) needs the image data fetched from a query. There's no way to fetch from a query right now (at least I don't know, maybe @notrab could help here).

Closes MAR-1897 and MAR-1898

@jpedroschmitz jpedroschmitz added documentation Improvements or additions to documentation react-renderer Issues and PR's related to @graphcms/rich-text-react-renderer labels Jul 21, 2021
@jpedroschmitz jpedroschmitz self-assigned this Jul 21, 2021
@linear
Copy link

linear bot commented Jul 21, 2021

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2021

🦋 Changeset detected

Latest commit: 5c2d1cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphcms/rich-text-react-renderer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpedroschmitz jpedroschmitz changed the title Joaopedro/mar 1897 add docs on how to use nextimage with docs(react): add examples for next image and gatsby link Jul 21, 2021
@linear
Copy link

linear bot commented Jul 21, 2021

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 4.37 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 4.31 KB (0%)
packages/types/dist/rich-text-types.cjs.production.min.js 51 B (0%)
packages/types/dist/rich-text-types.esm.js 64 B (0%)

@jpedroschmitz jpedroschmitz merged commit 1a0354c into main Jul 22, 2021
@jpedroschmitz jpedroschmitz deleted the joaopedro/mar-1897-add-docs-on-how-to-use-nextimage-with branch July 22, 2021 20:29
@github-actions github-actions bot mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation react-renderer Issues and PR's related to @graphcms/rich-text-react-renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant