Invalid Graph on Combobox

[rosaigor138]

Closes #433

[atilaajones]

You should include the issue number in the description. This way we'll do a review to understand the motivation behind the update. Also try to be more specific in the commit name, not just "fixed"

[atilaajones]

This change solved the problem. But I think you should also change the source of the problem: filtering should not return a file with a blank last line. The same goes for inserting the usual new graph, which also inserts a blank line.

[LBeghini]

This change solved the problem. But I think you should also change the source of the problem: filtering should not return a file with a blank last line. The same goes for inserting the usual new graph, which also inserts a blank line.

@atilaajones the blank line after filtering was an strategy proposed to fix the issue #397 . We can see the changes on the PR #403

[fsoupimenta]

I have observations about this PR:

1. On Linux (more precisely on Ubuntu 22.04.3 LTS) when a file with a blank line at the end is opened, the software already reads this line and throws it into the combo box, leaving the graph invalid. It's worth noting that this behavior only occurs on Linux.

2. When you click on an invalid graph in the combo box, the graph counter decreases, leaving duplicates.

Note

Test if this problem is related to this PR to resolve it here

3. @atilaajones The creation of a new graph does not add a blank line at the end, as can be seen below, it only breaks the line in the case of an insertion in the middle of the list, as this method is reused by save as well

GraphFilter/source/domain/utils_file.py

Lines 66 to 69 in 19e33e8

	try:
	changed_data[current_index] = new_g6 + "\n"
	except IndexError:
	changed_data.append("\n" + new_g6)

[atilaajones]

Test the reported behavior, then try to solve it in PR #444
@rosaigor138

[rosaigor138]

Test the reported behavior, then try to solve it in PR #444 @rosaigor138

I don't understand why that I need to make that changes on the change graph file PR

[LBeghini]

Working on macOS Sonoma version 14.1.1 Chip Apple M1

[fsoupimenta]

@rosaigor138 The blank line at the end is still read by the software in ubuntu

[atilaajones]

@fsoupimenta. I think this PR can be merged, right?