Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple edges simultaneously #457

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fsoupimenta
Copy link
Member

Closes #453
Closes #447

@fsoupimenta
Copy link
Member Author

@GraphFilter/version-3-0

The functionality has been implemented and is available for testing by running the application.
However, I believe that the responsibility for this issue belongs to the netgraph library, and not to us. That's why I took the initiative to open an issue in their repository with this request: paulbrodersen/netgraph#88

In addition, during implementation, i identified some bugs that caused the software to fail. To get around these problems, it was necessary to overwrite the netgraph method of adding nodes. This reinforces the idea that it is not our responsibility to implement this functionality.

Note

While we wait for a response from the netgraph, if you want to test the functionality, simply select several vertices at the same time using Ctrl + left mouse click and drag, then press the plus button + or = anywhere on the board.

@atilaajones
Copy link
Contributor

atilaajones commented May 1, 2024

@fsoupimenta
I did the tests.
I observed some unexpected behavior when running the procedure:

  1. Select several vertices using the rectangle with the left mouse button;
  2. Insert new vertex;
  3. The software slowed down a bit and lost the labels of the new vertices

The same behavior occurred when selecting using the CTRL button. Is this the same behavior you got?

Please note that the issue paulbrodersen/netgraph#88 has been answered, so please forward it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple edges simultaneously New vertex adjacent to selected vertices
2 participants