This repository has been archived by the owner on Sep 24, 2019. It is now read-only.
Use GraphQL Batch for find by id fields #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjoudrey
commented
Feb 11, 2017
| @@ -1,8 +1,8 @@ | |||
| development: | |||
| secret_key_base: <%= ENV["SECRET_KEY_BASE"] %> | |||
| secret_key_base: secret-for-development-not-so-secret | |||
There was a problem hiding this comment.
This was starting to annoy me. It kept asking me to set an ENV var in dev/test.
xuorig
reviewed
Feb 12, 2017
| resolve ->(_, args, _) { ::Person.find_by(id: args['id']) } | ||
| end | ||
|
|
||
| field :person, Graph.find_by_id_field(Graph::Types::Person, ::Person) |
xuorig
reviewed
Feb 12, 2017
| class << self | ||
| def find_by_id_field(type, model) | ||
| GraphQL::Field.define do | ||
| type type |
cjoudrey
force-pushed
the
graphql-batch
branch
from
59a0f48
to
1857ed2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at adding batching to simple find by id fields.