Add non-null to fields #25

xuorig · 2017-02-12T03:41:03Z

forgot about non nulls! Pretty sure all these fields are non-null, havent verified all of them but worst case well fix when we see errors. @cjoudrey

cjoudrey · 2017-02-12T18:22:51Z

app/models/graph/types/person.rb

        "The birth year of the person, using the in-universe standard of BBY or ABY"\
        " - Before the Battle of Yavin or After the Battle of Yavin. The Battle of Yavin"\
        " is a battle that occurs at the end of Star Wars episode IV: A New Hope.",
        property: :birth_year

-      field :eyeColor, types.String,
+      field :eyeColor, !types.String,


> Person.where(eye_color: nil).map(&:name) Person Load (0.4ms) SELECT "people".* FROM "people" WHERE "people"."eye_color" IS NULL => ["Wat Tambor", "Ratts Tyerell", "Captain Phasma"]

cjoudrey · 2017-02-12T18:28:53Z

app/models/graph/types/person.rb

+      field :homeworld, !Planet, "A planet that this person was born on or inhabits."
+      field :mass, !types.Int, "The mass of the person in kilograms."
+      field :name, !types.String, "The name of this person."
+      field :skinColor, !types.String, "The skin color of this person.", property: :skin_color


> Person.where(skin_color: nil).map(&:name) Person Load (0.2ms) SELECT "people".* FROM "people" WHERE "people"."skin_color" IS NULL => ["Chewbacca", "Captain Phasma"]

cjoudrey · 2017-02-12T18:29:32Z

app/models/graph/types/person.rb

-      field :mass, types.Int, "The mass of the person in kilograms."
-      field :name, types.String, "The name of this person."
-      field :skinColor, types.String, "The skin color of this person.", property: :skin_color
+      field :height, !types.Int, "The height of the person in centimeters."


> Person.where(height: nil).map(&:name) Person Load (0.2ms) SELECT "people".* FROM "people" WHERE "people"."height" IS NULL => ["Arvel Crynyd", "BB8", "Poe Dameron", "Rey", "Captain Phasma", "Finn"]

cjoudrey · 2017-02-12T18:29:52Z

app/models/graph/types/person.rb

-      field :skinColor, types.String, "The skin color of this person.", property: :skin_color
+      field :height, !types.Int, "The height of the person in centimeters."
+      field :homeworld, !Planet, "A planet that this person was born on or inhabits."
+      field :mass, !types.Int, "The mass of the person in kilograms."


Same here :(

cjoudrey · 2017-02-12T18:30:49Z

app/models/graph/types/person.rb

-      field :name, types.String, "The name of this person."
-      field :skinColor, types.String, "The skin color of this person.", property: :skin_color
+      field :height, !types.Int, "The height of the person in centimeters."
+      field :homeworld, !Planet, "A planet that this person was born on or inhabits."


Here too :(

cjoudrey · 2017-02-12T18:40:31Z

app/models/graph/types/planet.rb

-      field :name, types.String, "The name of this planet."
-      field :diameter, types.Int, "The diameter of this planet in kilometers."
+      field :name, !types.String, "The name of this planet."
+      field :diameter, !types.Int, "The diameter of this planet in kilometers."


> Planet.where(diameter: nil).count (0.2ms) SELECT COUNT(*) FROM "planets" WHERE "planets"."diameter" IS NULL => 17

😭

cjoudrey · 2017-02-12T18:40:52Z

app/models/graph/types/planet.rb


-      field :rotationPeriod, types.Int,
+      field :rotationPeriod, !types.Int,


> Planet.where(rotation_period: nil).count (0.2ms) SELECT COUNT(*) FROM "planets" WHERE "planets"."rotation_period" IS NULL => 13

😭

cjoudrey · 2017-02-12T18:42:30Z

app/models/graph/types/planet.rb

        "The number of standard hours it takes for this planet to complete a single rotation on its axis.",
        property: :rotation_period

-      field :orbitalPeriod, types.Int,
+      field :orbitalPeriod, !types.Int,


> Planet.where(orbital_period: nil).count (0.2ms) SELECT COUNT(*) FROM "planets" WHERE "planets"."orbital_period" IS NULL => 13

surprise! 😭

cjoudrey · 2017-02-12T18:42:45Z

app/models/graph/types/planet.rb

        "The number of standard days it takes for this planet to complete a single orbit of its local star.",
        property: :orbital_period

-      field :gravity, types.String,
+      field :gravity, !types.String,


This one too.

cjoudrey · 2017-02-12T18:43:43Z

app/models/graph/types/planet.rb


-      field :surfaceWater, types.Float,
+      field :surfaceWater, !types.Float,


population, climate, terrain, surfaceWater. All of these too. 😭

cjoudrey · 2017-02-12T18:45:23Z

app/models/graph/types/species.rb

-      field :classification, types.String, "The classification of this species, such as \"mammal\" or \"reptile\"."
-      field :designation, types.String, "The designation of this species, such as \"sentient\"."
+      field :name, !types.String, "The name of this species."
+      field :classification, !types.String, "The classification of this species, such as \"mammal\" or \"reptile\"."


> Species.where(classification: nil).count (1.3ms) SELECT COUNT(*) FROM "species" WHERE "species"."classification" IS NULL => 6

cjoudrey · 2017-02-12T18:46:08Z

app/models/graph/types/species.rb

-      field :language, types.String, "The language commonly spoken by this species."
-      field :homeworld, Graph::Types::Planet, "A planet that this species originates from type."
+      field :language, !types.String, "The language commonly spoken by this species."
+      field :homeworld, !Graph::Types::Planet, "A planet that this species originates from type."


(1.9ms) SELECT COUNT(*) FROM "species" WHERE "species"."homeworld_id" IS NULL => 2

cjoudrey · 2017-02-12T18:46:18Z

app/models/graph/types/species.rb

        description "Common skin colors for this species, null if this species does not typically have skin."
        resolve ->(species, _, _) do
          return unless colors = species.skin_colors
          colors.split(", ")
        end
      end

-      field :language, types.String, "The language commonly spoken by this species."
-      field :homeworld, Graph::Types::Planet, "A planet that this species originates from type."
+      field :language, !types.String, "The language commonly spoken by this species."


(0.1ms) SELECT COUNT(*) FROM "species" WHERE "species"."language" IS NULL => 1

xuorig · 2017-02-12T19:13:35Z

merging, only name is non null except for film

cjoudrey reviewed Feb 12, 2017

View reviewed changes

xuorig added 2 commits February 12, 2017 13:26

Add non-null to fields

f011964

fix nullable fields

06883f8

xuorig force-pushed the non-null-fields branch from 787e1c7 to 06883f8 Compare February 12, 2017 18:26

cjoudrey reviewed Feb 12, 2017

View reviewed changes

remove non nulls for most fields cuz bad data

fc4d088

xuorig merged commit 7e66c35 into master Feb 12, 2017

xuorig deleted the non-null-fields branch February 12, 2017 19:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add non-null to fields #25

Add non-null to fields #25

xuorig commented Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

cjoudrey Feb 12, 2017

xuorig commented Feb 12, 2017


		field :rotationPeriod, types.Int,
		field :rotationPeriod, !types.Int,


		field :surfaceWater, types.Float,
		field :surfaceWater, !types.Float,

Add non-null to fields #25

Add non-null to fields #25

Conversation

xuorig commented Feb 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xuorig commented Feb 12, 2017