Apollo Server 4 Upgrade #123
Conversation
…ion and optionally a cache
…or of the api class you extend MongoDataSource to
Apollo Server 4 Upgrade
Updated README
Typescript generics fix
README and package changes
index.d.ts
Outdated
| @@ -1,21 +1,21 @@ | |||
| declare module 'apollo-datasource-mongodb' { | |||
| import { DataSource } from 'apollo-datasource' | |||
| declare module 'apollo-mongo-datasource' { | |||
There was a problem hiding this comment.
Isnt this supposed to be apollo-datasource-mongodb itself since we are making changes to the same package?
There was a problem hiding this comment.
You're right, I was originally going to create a separate package because I wasn't sure this repo was still being maintained. Just fixed the module name, should be good now
There was a problem hiding this comment.
IMO, I think it would be better to maintain this as a separate package, since I dont see this getting merged anytime soon.
This is something my team has also been dependent on.
|
@nnoce14 thanks so much for submitting! and @devileye98 for reviewing 🙏 Do we need any more automated tests to make sure this works with AS v4? Could you also add a note to the readme saying which versions of this package support which AS versions, and a link to the old (current) version of the README/docs? |
I forked out this PR and tested it against our application. Apart from a few minor changes in our types, we were able to get the server up and running and were also able to run our E2E and unit tests |
| test('Data Source with Context', async () => { | ||
| const users = new Users({ modelOrCollection: UserModel, context: { token: '123' }}) | ||
|
|
||
| expect(users.context.token).toBe('123') | ||
| }) | ||
|
|
||
| test('Data Source with Context that contains a User', async () => { | ||
| const users = new Users({ modelOrCollection: userCollection, context: { user: alice }}) | ||
| const user = await users.findOneById(alice._id) | ||
|
|
||
| expect(user.name).toBe('Alice') | ||
| expect(users.context.user.name).toBe(user.name) | ||
| }) |
There was a problem hiding this comment.
@lorensr I added these two tests to check the behavior for providing Context to datasources in Apollo Server 4. I also made minor changes to the construction of the Users datasource. Let me know if you think more tests are necessary. I also added the old README file and added a note to both which explains the versioning.
I just updated mongoose from v5 to v7, which is latest. I also updated mongodb from v3 to v4. However, the latest version is v5 but I was unable to get that to work because of an ongoing issue with BSON v5 found here |
I think we resolved this by updating the Bson package. I think that should resolve the issue. |
Yeah that seemed to work, thank you. I updated bson as well the other day, but it was still throwing me the same error at the time. All good now, mongodb is latest version. |
|
@lorensr , can we get this PR merged since I think all the comments are addressed? |
|
Any hope of this getting merged? |
|
Sorry folks, very low on time these days! Lmk if anyone's interested in helping out with maintenance. Thanks for the ping Nick.
https://github.com/GraphQLGuide/apollo-datasource-mongodb/releases/tag/0.6.0 https://www.npmjs.com/package/apollo-datasource-mongodb?activeTab=versions |
Made changes to MongoDataSource to be compliant with how data sources were changed in Apollo Server 4. See latest comment on Issue #114 for more information.