fix: Serial Execution Strategy #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrownedPhoenix
force-pushed
the
fix/serial-execution-strategy
branch
from
3cb735e
to
f0812cd
Compare
There was a problem hiding this comment.
Looks excellent, other than a minor formatting violation. Thanks @CrownedPhoenix!
|
Fixes #86 |
Updated test mocks to properly expose non-serial behavior. Updated SerialFieldExecutionStrategy to actually be serial.
CrownedPhoenix
force-pushed
the
fix/serial-execution-strategy
branch
3 times, most recently
from
421281a
to
d9379d0
Compare
|
I'm going to bypass the formatting requirement for now because it doesn't tell us what needs to be formatted. I will create a followup MR to rework the formatting system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed a bug in mocks for
FieldExecutionStrategyTestsaffectingtestSerialFieldExecutionStrategyWithMultipleFieldErrors.Prior to the change, the test appeared to be serial because the mocking framework blocked execution before returning the future - as opposed to blocking execution on the EventLoop.
The
SerialFieldExecutionStrategyexecution resolution implementation used NIO's.flattenon an array of futures (which all executed concurrently). However, the creation of these futures was thread blocked specifically in the tests, leading to the appearance of serial execution.These changes correct the catalyzing test mock as well as
SerialFieldExecutionStrategysuch that it resolves fields in a truly serial fashion.