Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compiler warnings #140

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

NeedleInAJayStack
Copy link
Member

Minor tweaks to fix compiler warnings

Copy link
Member

@paulofaria paulofaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the message regarding forEach? I'm curious, haha.

@NeedleInAJayStack
Copy link
Member Author

NeedleInAJayStack commented Mar 19, 2024

What was the message regarding forEach? I'm curious, haha.

These lines failed the preferForLoop rule :

/repo/Tests/GraphQLTests/FieldExecutionStrategyTests/FieldExecutionStrategyTests.swift:262:1: error: (preferForLoop) Convert functional forEach calls to for loops.
/repo/Tests/GraphQLTests/FieldExecutionStrategyTests/FieldExecutionStrategyTests.swift:311:1: error: (preferForLoop) Convert functional forEach calls to for loops.

It looks like this was enabled by default in SwiftFormat a few months ago: nicklockwood/SwiftFormat@9c8eb47

@NeedleInAJayStack NeedleInAJayStack merged commit 63c74fa into GraphQLSwift:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants