Fixes bug with multithreaded event loop #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2021 14:51
This causes them to be unstable and fail.
This fixes all testing issues
NeedleInAJayStack
changed the title
|
Hey @paulofaria, just let me know if you'd like me to assign you as the reviewer, or what your workflow is. Thanks! |
|
It looks like GH Actions settings have changed and CI isn't passing anymore. I'll take a look at that later this week, if you don't beat me to it. |
|
@paulofaria Good call. I just fixed the GitHub CI issue in this pull request, and it's passing now. I also put in an additional pull request to fix the same issue in Graphiti: GraphQLSwift/Graphiti#53 |
|
@NeedleInAJayStack thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.