-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework AST to be more type safe and allow mutation #95
Draft
lukel97
wants to merge
19
commits into
GraphQLSwift:main
Choose a base branch
from
minm-inc:mutatable-visitor
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 22, 2021
-
Rework AST to be more type safe and allow mutation
Also replace existential types with enums
Configuration menu - View commit details
-
Copy full SHA for 876c29b - Browse repository at this point
Copy the full SHA 876c29bView commit details -
Remove kinds as they are no longer needed
They would be necessary in a duck-typed language such as TypeScript but we can check at runtime with casts in Swift
Configuration menu - View commit details
-
Copy full SHA for 75fb18f - Browse repository at this point
Copy the full SHA 75fb18fView commit details
Commits on Jan 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f12c6ba - Browse repository at this point
Copy the full SHA f12c6baView commit details
Commits on Feb 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 13a95b0 - Browse repository at this point
Copy the full SHA 13a95b0View commit details
Commits on Feb 23, 2022
-
Fix doTypesOverlap when seeing if object overlaps with interface
It's possible here that typeA is also an interface
Configuration menu - View commit details
-
Copy full SHA for 6495218 - Browse repository at this point
Copy the full SHA 6495218View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac2a4ed - Browse repository at this point
Copy the full SHA ac2a4edView commit details
Commits on Feb 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ac9fbbc - Browse repository at this point
Copy the full SHA ac9fbbcView commit details
Commits on Mar 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1d3e38 - Browse repository at this point
Copy the full SHA f1d3e38View commit details
Commits on Apr 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8a71abf - Browse repository at this point
Copy the full SHA 8a71abfView commit details
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0765b9f - Browse repository at this point
Copy the full SHA 0765b9fView commit details -
To do so, need to make it conform to AnyObject, which in turn forces us to use Swift 5.6 any syntax for existential types throughout
Configuration menu - View commit details
-
Copy full SHA for 3933850 - Browse repository at this point
Copy the full SHA 3933850View commit details -
Configuration menu - View commit details
-
Copy full SHA for edcfcba - Browse repository at this point
Copy the full SHA edcfcbaView commit details
Commits on Jun 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fb0397c - Browse repository at this point
Copy the full SHA fb0397cView commit details
Commits on Jul 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 215d0fa - Browse repository at this point
Copy the full SHA 215d0faView commit details
Commits on Jul 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for de70703 - Browse repository at this point
Copy the full SHA de70703View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e830cd - Browse repository at this point
Copy the full SHA 1e830cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a4e165 - Browse repository at this point
Copy the full SHA 3a4e165View commit details -
Configuration menu - View commit details
-
Copy full SHA for d476ab0 - Browse repository at this point
Copy the full SHA d476ab0View commit details
Commits on Aug 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a353056 - Browse repository at this point
Copy the full SHA a353056View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.