Fix: Federation Introspection #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the double-underscore introspection error, as well as avoiding polluting of the GraphQL schema
|
Fixes #102 |
|
P.S. @d-exclaimation, I used Pioneer for the first time to get a debugging Vapor/GraphiQL instance up for this fix, and it was unbelievably quick and easy. Exceptional work on that package! |
d-exclaimation
approved these changes
Feb 17, 2023
|
@d-exclaimation Good call. We've got federation unit tests here, but you're right - some integration tests for federation compliance would be great as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the federation implementation to avoid creating
__resolveReferencefields on each entity. Instead, the appropriate entity resolver function is generated, stored, and referenced outside the GraphQL object itself. This avoids polluting the GraphQL object with unnecessary fields.