Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swift 5.8 & 5.9 workflow #125

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

samisuteria
Copy link
Contributor

@samisuteria samisuteria commented Oct 12, 2023

Also ran swiftformat since the workflow was failing.

Copy link
Member

@NeedleInAJayStack NeedleInAJayStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, thanks for running the formatter. It's frustrating that it doesn't seem to stay consistent across versions.

Thanks!

@NeedleInAJayStack
Copy link
Member

@samisuteria Hey, I made some CI changes to fix the MacOS runner. Would you mind rebasing on main and add in the Swift 5.8 again? Thanks again for these changes.

@samisuteria
Copy link
Contributor Author

@NeedleInAJayStack made the changes :)

Copy link
Member

@NeedleInAJayStack NeedleInAJayStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NeedleInAJayStack NeedleInAJayStack merged commit 742dba5 into GraphQLSwift:main Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants