Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Directive Tests #134

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Add Directive Tests #134

merged 6 commits into from
Apr 3, 2024

Conversation

samisuteria
Copy link
Contributor

I had to update the GraphQL package version since the pinned version was failing the tests.

NeedleInAJayStack
NeedleInAJayStack previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@NeedleInAJayStack NeedleInAJayStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@samisuteria samisuteria mentioned this pull request Mar 20, 2024
Merged
@NeedleInAJayStack
Copy link
Member

I added a tag for your GraphQL changes. Thanks again for digging into those! https://github.com/GraphQLSwift/GraphQL/releases/tag/2.9.2

@samisuteria
Copy link
Contributor Author

Updated the package :)

@NeedleInAJayStack NeedleInAJayStack merged commit 3f15434 into GraphQLSwift:main Apr 3, 2024
9 checks passed
@samisuteria samisuteria deleted the directive-tests branch August 5, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeedleInAJayStack NeedleInAJayStack NeedleInAJayStack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samisuteria @NeedleInAJayStack