Fix: Wrapped Aliased Type Resolution #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, an out-of-order declaration that causes a type reference naming issue
The TypeProvider contains an additional collection of all SwiftTypes and their aliased GraphQL name. These names are used when resolving TypeReferences, so out-of-order references with an alias are no longer mis-addressed.
NeedleInAJayStack
force-pushed
the
fix/wrapped-aliased-type-resolution
branch
from
38e4b3f
to
1484360
Compare
|
Hey @paulofaria, you mind giving this one a quick review? |
|
Got this error message when trying to merge.
|
|
@paulofaria Woah, weird. It let me merge it fine... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #41
This added a collection of all SwiftTypes and their aliased GraphQL names to TypeProvider. These names are collected before any GraphQL types are created, and are used when resolving TypeReferences, so out-of-order references to aliased types are no longer mis-addressed.
To do so, we had to add a
setGraphQLNamefunction to the Component class, and implementations for all GraphQL Type components (Enum, Input, Interface, Scalar, Schema, Type, and Union). Schema construction now goes through all components to collect names prior to building up the GraphQL schema objects.