Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"keep_screen_on_enabled" feature that is not documented anywhere #2248

Open
olologin opened this issue Jun 12, 2023 · 1 comment
Open

"keep_screen_on_enabled" feature that is not documented anywhere #2248

olologin opened this issue Jun 12, 2023 · 1 comment

Comments

@olologin
Copy link

olologin commented Jun 12, 2023

We discussed it here:
https://discuss.grapheneos.org/d/2352-screen-sporadically-doesnt-turn-off-automatically/14

Originally everyone thought this was some bug, but it turns out to be a feature that is enabled by default, and leads to unexpected dimming behavior (Screen can stay enabled for 10 minutes, ignoring screen timeout set by user in settings), the main problem IMO is that it is not explained or documented anywhere, not configurable:

This is due to "ScreenUndimDetector.java" and seems to have started with Android 12 December update.
If you undim the screen twice within 5 minutes, the screen is then kept on for 10 min.You can test this as follows:
Set the display timeout to 30s
Let the screen dim (but not turn off)
Brighten the screen by touching it
Let the screen dim again (but not turn off)
Brighten the screen by touching it
Now the screen won't time out on its own (for about 10 minutes)

Could you please just disable it by default, or maybe somehow make this behavior obvious to user (Add some checkbox to settings app)?
Patch that disables it in LineageOS (Although it doesnt look like it is compatible with GOS sources, I am not an expert):
https://review.lineageos.org/c/LineageOS/android_vendor_lineage/+/333526

@olologin olologin changed the title Please disable "keep_screen_on_enabled" feature that is not documented anywhere Please do something with "keep_screen_on_enabled" feature that is not documented anywhere Jun 12, 2023
@olologin
Copy link
Author

Not sure if you are allowed to diverge from stock pixel firmware too much, but it seems this feature is also enabled there by default, and people are complaining:
https://support.google.com/pixelphone/thread/139273468?hl=en&msgid=140497690

@olologin olologin changed the title Please do something with "keep_screen_on_enabled" feature that is not documented anywhere "keep_screen_on_enabled" feature that is not documented anywhere Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant