Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make menu lists searchable #1499

Merged
merged 7 commits into from
Mar 9, 2024
Merged

Make menu lists searchable #1499

merged 7 commits into from
Mar 9, 2024

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Dec 10, 2023

Searchable font list as suggested by @1oonie. All of the other menus are also searchable.

Closes #1503

@Keavon
Copy link
Member

Keavon commented Dec 11, 2023

I'm presently working through these and checking them off as I go:

  • Left/Right/Up/Down keys need to preventDefault when they move the menu highlight or open/close a submenu
  • Spacebar/Enter to activate a submenu entry throws a console error (but clicking works fine, and also it's fine for non-submenus)
  • Fix CSS for search box
  • Deleting all text from the search needs to remove the search bar and return to how it started
  • Fix the bug where, bizarrely, Undo doesn't go past one step and Redo doesn't work at all, even if clicked through the menus instead of using the hotkeys (and even though no Rust files have changed!)
  • Backspacing to clear (and thus end) the search prevents typing again to enter a new search
  • Make it so opening a submenu deselects the search bar text so, for example, you can activate a submenu entry with the spacebar without typing a space in the previous menu's search box
  • Make searching in a submenu possible by opening the search box in that submenu while moving focus away from the previous menu's search box
  • Fix TS error in <svelte:self ... bind:this={...} />
  • Finish code review
  • Escape should close the search, not the whole menu (later)
  • Remove the FontInput component (later)
  • The highlight gets transferred to another entry (or lost if all are filtered away) upon filtering the highlighted item away (later)
  • Using Tab to navigate between menu bar items and Space to open them lets you open multiple at once (later)

I should probably get this done in the next day or two. It's not a release blocker so that's my current focus. We can do another release once this is merged.

@Keavon Keavon force-pushed the master branch 3 times, most recently from 20eb9c1 to 5c7e04a Compare December 21, 2023 02:43
@Keavon Keavon changed the title Make the menu list (and font lists) searchable Make menu lists (and font lists) searchable Dec 24, 2023
@Keavon Keavon changed the title Make menu lists (and font lists) searchable Make menu lists searchable Dec 24, 2023
@0HyperCube
Copy link
Member Author

@Keavon It is probably not necessary to add these features now - I think we could merge this as a non-breaking UX improvement and then add the rest of these improvements later.

@Keavon Keavon enabled auto-merge (squash) March 9, 2024 10:51
@Keavon Keavon merged commit b31e8f7 into master Mar 9, 2024
2 checks passed
@Keavon Keavon deleted the searchable-font-list branch March 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu lists like font selection should be searchable
2 participants