Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nudging and nudge resizing #1501

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix nudging and nudge resizing #1501

merged 1 commit into from
Dec 11, 2023

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Dec 10, 2023

No description provided.

@Keavon Keavon changed the title Fix nudge resizing pivot Fix nudging and nudge resizing Dec 10, 2023
@Keavon
Copy link
Member

Keavon commented Dec 10, 2023

Could you please make this operate in document space, not viewport space? So it should always nudge everything by 1px (or 10px if Shift is held) regardless of viewport zoom. Then you might encounter the issue described in #1317, which occurred upon switching from viewport to document space. I could also just edit that issue to describe the request to change to being relative to document space, and we proceed to merge this as-is for now (since having it at all is preferable to delaying until that can be fixed into its ideal form).

@Keavon
Copy link
Member

Keavon commented Dec 11, 2023

I decided it's a better use of your time @0HyperCube to merge this now so you can choose to make nudge resizing operate in document space at a time of your choice instead of needing to do it now, or it can be left to the community to work on if you judge that you have bigger fish to fry compared to this quality-of-life improvement/papercut. So I updated #1317 to describe the improvement of switching it to document space (instead of its previous focus, which was a bug resulting from switching it to document space, as that's not as relevant yet). Feel free to tackle that now, or whenever, or leave it for the community— it's no longer critical path as a part of the document graph refactor tracking issue.

@Keavon Keavon merged commit 27960f3 into master Dec 11, 2023
2 checks passed
@Keavon Keavon deleted the fix-nudge-pivot branch December 11, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants