Save work periodically to reduce loss from crashes #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please comment in the issue so GitHub lets me assign it to you. Looking forward to landing this! |
|
Thanks, I assigned it to you. Once you've finished implementing the feature and it seems to work in a production-ready way, please mark the PR as ready for review and also ping me so I notice and come to take a look with QA testing and code review. Welcome! |
|
@Keavon are you d'acorde with the approach taken here? Currently this saves the document after 30 s of inactivity. Should we add a second longer timer which forces a save if no inactivity was sufficiently long? |
|
I was thinking that maybe a good time to save would be, if 30 seconds have elapsed, when the history stack changes. Does that seem feasible? |
Keavon
force-pushed
the
master
branch
2 times, most recently
from
887d99b
to
3f76526
Compare
Comeza
force-pushed
the
master
branch
2 times, most recently
from
8b60cbe
to
5ea0444
Compare
|
Keavon
reviewed
Feb 19, 2024
Keavon
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #929