-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore select tool functionality and shallow select mode #1583
Conversation
d07c8a1
to
741033a
Compare
741033a
to
edffd7f
Compare
887d99b
to
3f76526
Compare
edffd7f
to
7a72400
Compare
I can't believe you managed to remain code negative while adding back all this functionality— including Deep/Shallow selection which used to be that hideous mess of hundreds of lines of highly indented code. This is working remarkably well in general! I just have a few notes for how we can further improve the UX:
I'm more than happy to merge this in any state and continue those in future PRs. I'm just making a note of them here or I can transfer them to a separate issue if you'd prefer we save those enhancements for later. |
bbd5ef7
to
cbf347a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good!
3c11f71
to
e29e4a8
Compare
Thanks! |
And one of us can move the Deep/Shallow Select dropdown to the user preferences at any point in the future. I'm personally ambivalent about whether it's part of the tool options or the preferences, but I respect your opinion about that as you mentioned in Discord. But I'd say it's moderately low priority to change at this moment so feel free to submit a PR anytime now or later in the future. |
Restore select tool functionality: