Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freehand tool: Allow extension of existing paths #1594

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

zhiyuang
Copy link
Contributor

@zhiyuang zhiyuang commented Feb 2, 2024

Closes #1549

@zhiyuang
Copy link
Contributor Author

zhiyuang commented Feb 2, 2024

not support snapping to the anchor yet.

@Keavon
Copy link
Member

Keavon commented Feb 2, 2024

!build

Copy link

github-actions bot commented Feb 2, 2024

📦 Build Complete for e1e2bb6
https://9086baa4.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 2, 2024

This is awesome! So much fun to play around with.

capture_2_.1.mp4

@Keavon Keavon changed the title Append to a existing path in Freehand Tool. Freehand tool: Allow extension of existing paths Feb 4, 2024
Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idiomatic code!

@Keavon Keavon merged commit a4a2680 into GraphiteEditor:master Feb 4, 2024
2 checks passed
@Keavon
Copy link
Member

Keavon commented Feb 18, 2024

@zhiyuang would you mind fixing this bug I just discovered?

capture_10_.mp4

(This also happens for rotation and scale)

@zhiyuang
Copy link
Contributor Author

sure, I will find a time to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the Freehand tool to append to an existing layer's path
2 participants