Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and rename Graphene data types, and add many comments #1620

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Feb 21, 2024

  • Combine NodeImplementation into DocumentNodeImplementation to use only the latter everywhere that formerly used either (NodeImplementation::DocumentNode became DocumentNodeImplementation::Network)
  • Rename DocumentNodeImplementation::Unresolved to DocumentNodeImplementation::ProtoNode
  • Split ProtoNodeInput::Node(NodeId, bool) which stored a boolean indicating if it's treated as a lambda, into ProtoNodeInput::Node(NodeId) and ProtoNodeInput::NodeLambda(NodeId)
  • Add a good number of comments throughout Graphene

@Keavon Keavon merged commit a02b162 into master Feb 21, 2024
2 checks passed
@Keavon Keavon deleted the comments branch February 21, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants