Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change devcontainer image to Debian to support ARM platforms #1636

Merged

Conversation

haikalvidya
Copy link
Contributor

@haikalvidya haikalvidya commented Feb 29, 2024

This pull request aims to facilitate running the development container on ARM-based processors by switching the base image to Debian. Previously, the image was specified as "mcr.microsoft.com/devcontainers/universal:2", which might not be compatible with ARM architectures based on this information (https://github.com/devcontainers/images/blob/main/src/universal/README.md).

The decision to opt for the Debian base image is grounded in the documentation of the Graphite, which suggests compatibility with Debian distributions. Although there are two options available (base:ubuntu and base:debian), choosing Debian aligns better with the documented requirements, ensuring a smoother development experience. And I've confirmed it runs fine on the Github Codespace and of course ARM-based machine.

more information about the images : https://github.com/devcontainers/images/blob/main/src/base-debian/README.md

@Keavon
Copy link
Member

Keavon commented Feb 29, 2024

Thanks for researching this!

The decision to opt for the Debian base image is grounded in the documentation of the Graphite, which suggests compatibility with Debian distributions.

I'm curious if you could clarify what you mean by this? What Graphite documentation mentions Debian?

@haikalvidya
Copy link
Contributor Author

haikalvidya commented Mar 2, 2024

Thanks for researching this!

The decision to opt for the Debian base image is grounded in the documentation of the Graphite, which suggests compatibility with Debian distributions.

I'm curious if you could clarify what you mean by this? What Graphite documentation mentions Debian?

ooohh, this one https://graphite.rs/volunteer/guide/getting-started/ mention On Debian-based Linux distributions, you may need to install the following packages:

and as i mentioned in this

image

when using Codespace 2-core machine the error occurred more often on ubuntu one, which mean Debian OS is lighter on the resource than Ubuntu OS.

@Keavon
Copy link
Member

Keavon commented Mar 3, 2024

Gotcha, thanks for explaining. That mention in the getting started docs just means any Debian-based Linux distro (where most commonly that means Ubuntu), there's no particular preference for the base Debian distro or anything. However your claim about Debian being lighter than Ubuntu seems like a valid point in favor of the former. But that issue you found on Codespaces 2-core machines makes me wonder, does that happen more with the Debian image compared to the (potentially even lighter) image we're using currently which was recommended by the Codespaces docs?

@Keavon
Copy link
Member

Keavon commented Mar 3, 2024

The relevant issue: devcontainers/images#545

@haikalvidya
Copy link
Contributor Author

The image(photo) that I send is from master codebase of Graphite, so the image was the one that currently on codebase right now. And about that relevant issue on image mcr.microsoft.com/devcontainers/universal:2 install oryx that not support arm-based machine, and I think on Graphite development we dont need that.

@Keavon
Copy link
Member

Keavon commented Mar 5, 2024

@TrueDoctor @0HyperCube do you have any thoughts about which OS to use for this? Does Debian seem like a good choice compared to universal?

@Keavon Keavon force-pushed the update-image-devcontainer-debian branch from 18667ee to ac13e9a Compare March 5, 2024 22:23
@Keavon Keavon changed the title Change image devcontainer to base debian to provide arm based Change devcontainer image to Debian to support ARM platforms Mar 5, 2024
@Keavon Keavon enabled auto-merge (squash) March 5, 2024 22:24
@Keavon Keavon merged commit a47fff9 into GraphiteEditor:master Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants