Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal consistency of layer ordering when grouping #1645

Merged

Conversation

moOsama76
Copy link
Contributor

@moOsama76 moOsama76 commented Mar 3, 2024

Partly closes #1633 (fixes "Grouping" > "Internal Consistency").

Grouping layers preserve the order that they were sorted once those layers end up in the new group

@Keavon Keavon force-pushed the grouping_layers_internal_sort branch from 6efbb10 to edaa970 Compare March 5, 2024 22:18
@GraphiteEditor GraphiteEditor deleted a comment from github-actions bot Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

📦 Build Complete for edaa970
https://255c43af.graphite.pages.dev

@Keavon Keavon requested a review from 0HyperCube March 5, 2024 22:35
@Keavon Keavon changed the title Internal consistency when group layers Fix internal consistency of layer ordering when grouped Mar 5, 2024
@GraphiteEditor GraphiteEditor deleted a comment from moOsama76 Mar 5, 2024
@Keavon Keavon force-pushed the grouping_layers_internal_sort branch from dde71e9 to 2e4a1bc Compare March 7, 2024 09:14
@Keavon Keavon force-pushed the grouping_layers_internal_sort branch from 2e4a1bc to 16d1b40 Compare March 9, 2024 05:11
@Keavon Keavon changed the title Fix internal consistency of layer ordering when grouped Fix internal consistency of layer ordering when grouping Mar 9, 2024
@Keavon Keavon enabled auto-merge (squash) March 9, 2024 05:13
@Keavon Keavon merged commit 69c6f44 into GraphiteEditor:master Mar 9, 2024
2 checks passed
@moOsama76
Copy link
Contributor Author

this also fixes the Internal consistency of ungrouping (a sub-issue of #1633 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid layers being reordered when dealing with groups
3 participants