Add auto-panning to the Artboard tool #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbertronnie
force-pushed
the
add-auto-panning-to-artboard-tool
branch
from
61d7243
to
121724e
Compare
|
Would it be reasonable to turn this PR into one which encompasses all the remaining tools, or do you think it requires too many changes and too much effort per tool that it'd be better to split it into one PR per tool? |
|
I stopped at one tool since I wanted confirmation on the way I have abstracted the code to I can combine it in one PR but it will take more than 2 weeks to complete it and diff size will definitely be above 500 lines. |
|
In that case, several PRs sounds preferable. Is this one ready for review and merging? |
Yes |
0HyperCube
approved these changes
Mar 8, 2024
Keavon
force-pushed
the
add-auto-panning-to-artboard-tool
branch
from
121724e
to
88816aa
Compare
|
!build |
|
Keavon
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #1527
auto_panning.rs.ResizingBounds,DraggingorDrawing.AnimationFrameas specified in https://discord.com/channels/731730685944922173/881073965047636018/1214107184200421396