Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cancellation of pivot drag in Select tool #1658

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Allow cancellation of pivot drag in Select tool #1658

merged 2 commits into from
Mar 9, 2024

Conversation

milan-sedivy
Copy link
Contributor

@milan-sedivy milan-sedivy commented Mar 9, 2024 •
edited

Added Abort - tested in multiple scenarios:

  • ESC/RMB when DraggingPivot
  • Change tool when DraggingPivot
  • Tested other actions such as resizing that might be affected by the change
  • Tested if rotations around pivot match after aborting

Partly closes #1657

@milan-sedivy milan-sedivy changed the title Add Abort to SelectToolFsmState::DragginPivot state Select Tool - Make pivot drag an abortable transaction Mar 9, 2024
@Keavon Keavon changed the title Select Tool - Make pivot drag an abortable transaction Allow cancelation of pivot drag in Select tool Mar 9, 2024
@Keavon Keavon changed the title Allow cancelation of pivot drag in Select tool Allow cancellation of pivot drag in Select tool Mar 9, 2024
@milan-sedivy milan-sedivy marked this pull request as ready for review March 9, 2024 08:12
@Keavon
Copy link
Member

Keavon commented Mar 9, 2024

!build

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

📦 Build Complete for 20b5e95
https://74e9dd4c.graphite.pages.dev

@Keavon Keavon merged commit 4cbba3d into GraphiteEditor:master Mar 9, 2024
2 checks passed
@Keavon Keavon mentioned this pull request Mar 9, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All drag actions should be cancellable with Esc/RMB
2 participants
@milan-sedivy @Keavon