Don't save undo/redo history when aborting transactions #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
approved these changes
Mar 10, 2024
Keavon
force-pushed
the
fix-undo-for-aborted-transaction
branch
from
d3b0642
to
de2a2b0
Compare
|
!build |
|
Keavon
reviewed
Mar 11, 2024
editor/src/messages/portfolio/document/document_message_handler.rs
Outdated
Show resolved
Hide resolved
Keavon
reviewed
Mar 11, 2024
editor/src/messages/portfolio/document/document_message_handler.rs
Outdated
Show resolved
Hide resolved
|
Redo history is still wiped out (as before), but now it doesn't put the wrong history state into the redo history. E.g. previously, you could drag a shape upwards and abort, and that upward location where you aborted would be stored in one step of redo history. Now it simply loses all redo history, which is a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now solved with a simple split of undo/redo into a "forgettable" version and non-forgettable.
Fixes #1659