Fix ungrouping bugs to preserve layer ordering and prevent incorrect layer deletion #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
changed the title
5 tasks
Keavon
requested changes
Mar 16, 2024
There was a problem hiding this comment.
This looks nice! But there's one issue remaining that I've found. Your fix for the case you reported in #1671 does, indeed, prevent the layers from being deleted. However it reorders them so b appears above a. Can you please fix that before merging this?
Keavon
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1671
Sub-issue: external consistency of ungrouping, closes #1633