Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block the undo shortcut while dragging with a tool #1675

Merged

Conversation

milan-sedivy
Copy link
Contributor

Big thanks to @0HyperCube

This is a fix that is presented in the issue as 1) i.e. prevent it by sending a NOOP instead of UNDO when CTRL + Z + LMB is pressed.

Closes #1674

@Keavon Keavon force-pushed the prevent-undo-while-lmb-pressed branch from c9d303f to 456a096 Compare March 11, 2024 22:48
@Keavon
Copy link
Member

Keavon commented Mar 11, 2024

!build

@Keavon Keavon changed the title Add NOOP message and bind it to CTRL + Z + LMB Block undo shortcut while dragging with a tool Mar 11, 2024
Copy link

📦 Build Complete for 456a096
https://ebbe06e0.graphite.pages.dev

@Keavon Keavon changed the title Block undo shortcut while dragging with a tool Block the undo shortcut while dragging with a tool Mar 11, 2024
@Keavon Keavon merged commit c3a8861 into GraphiteEditor:master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performing an undo right before cancelling a tool's drag action results in a doubled undo
2 participants