Place new folders in the correct stack order relative to other selected layers #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
changed the title
|
!build |
|
|
We'd like it to be placed just above the least-nested layer/folder that has a selection:
Right this this goes at the very top which isn't desired. I see in your code, you're using an insert index of |
|
Yes sure, sorry about that
…On Tue, Mar 12, 2024 at 1:31 AM Keavon Chambers ***@***.***> wrote:
We'd like it to be placed just above the least-nested layer/folder that
has a selection:
image.png (view on web)
<https://github.com/GraphiteEditor/Graphite/assets/4388688/73a961bc-7489-4bc4-bd89-e5f18725fa0d>
Right this this goes at the very top which isn't desired. I see in your
code, you're using an insert index of 0 which will instead need to be
calculated accordingly.
—
Reply to this email directly, view it on GitHub
<#1678 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQEFUOLXIHDENR3FHDUY3ETYXZEG7AVCNFSM6AAAAABEQ5I4GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGYZTMMZSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
5 tasks
…erarchy (at the level of the least nested layer)
… `.then_some()`
|
Please see my diff (49ed337) to learn from my little cleanup so you can write more idiomatic and performant Rust in the future :) |
Keavon
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-issue: new folder creation, closes #1633