-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make auto-panning speed uniform #1690
Make auto-panning speed uniform #1690
Conversation
Shouldn't |
No, because it is truely the timestamp and not a time-delta. I thought that providing timestamp info would be better since one can easily derive time-delta from timestamp but the other way round is much harder. And its type is |
Ah, I just checked the requestAnimationFrame docs and I see now that it says it's a high DOMHighResTimeStamp. I had recalled that it gives a delta time which is why I thought that was what this was. Disregard my confusion, thanks for explaining. |
!build |
|
Or I just had an Idea: We can make a custom struct |
If you think that's cleaner, go ahead. Or if the current approach is simpler, feel free to keep it.
At some point I'd like to have an option to enable a framerate counter debug overlay. Although I don't know if this is a good way to implement that. It's also not that high priority since the browser dev tools can be used to show a framerate too. |
It will be cleaner, since in the future if some other feature requires time-delta, it can reuse it from Although I am thinking to skip frame count for now. It can be implemented when its need arises. |
Sounds good, I'd say go ahead with what's needed right now and it can always be extended later as you point out. |
399a875
to
f1a3033
Compare
f1a3033
to
53cc0dc
Compare
Closes #1527
Currently the speed of auto-panning depends on hardware performance or the number of shapes in the document.
This PR attempts to resolve it by making timestamp and time-delta information available inside the
InputPreprocessorMessageHandler
and updating it every frame.