Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Path tool's point dragging getting offset when viewport is panned #1693

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

nico-mayora
Copy link
Contributor

@nico-mayora nico-mayora commented Mar 18, 2024

Changes path tool implementation for previous_mouse_position to use document units instead of viewport units.

https://discord.com/channels/731730685944922173/881073965047636018/1212129024776740874

Previous behaviour

doesnt-work.mp4

Current behaviour

works.mp4

@Keavon
Copy link
Member

Keavon commented Mar 18, 2024

!build

Copy link

📦 Build Complete for 86b930f
https://8bc3195d.graphite.pages.dev

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Keavon Keavon changed the title FIX :: Moving a point with the path tool after panning correctly snaps the point to the cursor. Fix the Path tool's point dragging getting offset when viewport is panned Mar 18, 2024
@Keavon Keavon merged commit ed3f7ac into GraphiteEditor:master Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants