Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PWA theme-color for frontend to adhere to system theme #1716

Closed

Conversation

smarizvi110
Copy link
Contributor

Resolves #1338

@Keavon
Copy link
Member

Keavon commented Mar 30, 2024

Your PR changes the indentation to tabs in one, but not both, files. Could you please either make them both tabs or keep them as both spaces?

@smarizvi110
Copy link
Contributor Author

Your PR changes the indentation to tabs in one, but not both, files. Could you please either make them both tabs or keep them as both spaces?

Thanks for the heads up, done.

@Keavon
Copy link
Member

Keavon commented Mar 30, 2024

Except now you replaced all the indentation in index.html...

@smarizvi110
Copy link
Contributor Author

Except now you replaced all the indentation in index.html...

Ah sorry. Let me just fix that. I must've accidentally configured the indentations to be more like rust's way for that too. Fixed now. Thank you for the patience 🙏

frontend/index.html Outdated Show resolved Hide resolved
@Keavon
Copy link
Member

Keavon commented Mar 31, 2024

Where did you find that "auto" as a value is a solution to #1338? I can't find any reference to that value in my research, and it looks like this issue that would automatically adapt to light and dark themes is still an open discussion that, I don't think, has been implemented into browsers. I'm concerned this isn't a real solution to the issue (and for that reason I'm going to temporarily close this but please reply and I'm happy to reopen it). Thanks.

@Keavon Keavon closed this Mar 31, 2024
@smarizvi110
Copy link
Contributor Author

Where did you find that "auto" as a value is a solution to #1338? I can't find any reference to that value in my research, and it looks like this issue that would automatically adapt to light and dark themes is still an open discussion that, I don't think, has been implemented into browsers. I'm concerned this isn't a real solution to the issue (and for that reason I'm going to temporarily close this but please reply and I'm happy to reopen it). Thanks.

Stumbled across this as a fix that could work for PWAs by just trying it. It seemed to work on my end, and the PWA would change the title bar color in accordance with the theme. But yes, I agree that it doesn't seem to be a widely supported option and the issue you mentioned is definitely worth looking in to. I'll be on the lookout for a better solution with regards to the issue you mentioned, but this PR should indeed remain closed for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium PWA white window frame does not respect system dark theme
2 participants